As it turns out, Microsoft's $60 first-party wireless controller—which is available in a massive range of styles and finishes—is still the best choice for the most gamers. It's a far cry from the hyper customizability and overall quality of pricy options like the Elite or one of Scuf's professional controllers, but where it lacks specialization and eccentricity, it makes up for it in terms of flexibility versus price ratio.
Not only is the standard Xbox Wireless Controller available in a ridiculous range of designs—standard black/white, grey/green, blue, red, green/orange, and in stylings like Volcano Shadow, Minecraft, Ocean Shadow, and Gears of War, to name a few—but it's perfectly situated as a jack of all trades, master of none where the full suite of expected functionality is concerned. The materials are durable enough to last for years (given a modicum of care), and across its sticks, D-pad, shoulder triggers, and face buttons, there's really nothing to complain about. The sticks aren't as good as some of the custom sticks you can find on pricier controllers, sure, and the D-pad isn't perfect, but all in all the standard controller will provide the best value for the most people.
It's also worth mentioning that, for obvious reasons, Microsoft's first-party controllers tend to excel at the system's utility functions, such as plugging in a wide range of headphones and gaming headsets, syncing and maintaining a Bluetooth connection, and assigning controllers to specific Xbox accounts.